[#323] Remove lib/viem.ts re-export shim#324
Merged
realproject7 merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
Update all imports of publicClient from lib/viem to lib/rpc, then delete the unnecessary shim file. Fixes #323 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR removes the lib/viem.ts shim and updates all remaining imports to use lib/rpc directly. The change is minimal, consistent, and satisfies the queue item intent.
Findings
- [low] Issue #323 understated current usage;
lib/price.tsandlib/contracts/erc8004.tsalso imported the shim, and this PR correctly updates them too.- File:
lib/price.ts:2 - Suggestion: None; this is the right scope.
- File:
- [low] No remaining code imports of
lib/viemremain after this patch.- File:
src/app/api/cron/backfill/route.ts:3 - Suggestion: None.
- File:
Decision
Approve. lib/viem.ts is deleted, imports now point at lib/rpc, and local npm run build passes.
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean, minimal change. Verified:
- All 3 imports (
lib/price.ts,lib/contracts/erc8004.ts,src/app/api/cron/backfill/route.ts) updated fromlib/viem→lib/rpc lib/viem.tsdeleted (confirmed 404 on PR branch)- No remaining references to
lib/viemin the codebase - Single commit, correctly scoped to #323
This was referenced Mar 31, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/price.ts,lib/contracts/erc8004.ts,src/app/api/cron/backfill/route.ts) to importpublicClientfromlib/rpcinstead oflib/viemlib/viem.ts(1-line re-export shim flagged in audit [Pre-Mainnet] Contract integration audit checklist #320, items F1/F5)npm run buildpassesFixes #323
Test plan
npm run buildpassespublicClientfromlib/rpc)